✨ introduce webserver rpc endpoints for licenses #6946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdrobuliak66/osparc-simcore into introduce-vip-models-pricing-4-part
matusdrobuliak66
requested review from
GitHK,
pcrespov and
sanderegg
as code owners
matusdrobuliak66
added
the
a:webserver
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6946 +/- ##
==========================================
+ Coverage 88.12% 88.14% +0.01%
==========================================
Files 1587 1234 -353
Lines 62168 52633 -9535
Branches 2008 997 -1011
==========================================
- Hits 54783 46391 -8392
+ Misses 7050 6048 -1002
+ Partials 335 194 -141
Continue to review full report in Codecov by Sentry.
|
bisgaard-itis
approved these changes
Dec 11, 2024
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Cool, thanks a lot for the quick additions. I will start exposing these on the api-server side
.../service-library/src/servicelib/rabbitmq/rpc_interfaces/webserver/licenses/licensed_items.py
Show resolved
Hide resolved
GitHK
approved these changes
Dec 11, 2024
sanderegg
approved these changes
Dec 11, 2024
pcrespov
approved these changes
Dec 11, 2024
|
matusdrobuliak66
merged commit e94782d
into
ITISFoundation:master
90 of 93 checks passed
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
get_licensed_itemsis functional@bisgaard-itis will implement the api server part
Related issue/s
How to test
Dev-ops checklist